Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the log/noop package #4943

Merged
merged 4 commits into from Feb 20, 2024
Merged

Add the log/noop package #4943

merged 4 commits into from Feb 20, 2024

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Feb 18, 2024

Resolve #4910

@MrAlias MrAlias added area:logs Part of OpenTelemetry logs Skip Changelog PRs that do not require a CHANGELOG.md entry labels Feb 18, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 18, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3fe7401) 82.6% compared to head (cf6f180) 82.6%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4943   +/-   ##
=====================================
  Coverage   82.6%   82.6%           
=====================================
  Files        237     238    +1     
  Lines      19031   19036    +5     
=====================================
+ Hits       15735   15742    +7     
+ Misses      3005    3003    -2     
  Partials     291     291
Files Coverage Δ
log/noop/noop.go 100.0% <100.0%> (ø)

... and 1 file with indirect coverage changes

@MrAlias MrAlias marked this pull request as ready for review February 18, 2024 16:15
pellared
pellared approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just a question to a comment for clarification and a proposal for doc comment. LGTM.

log/noop/noop_test.go Show resolved Hide resolved
log/noop/noop.go Show resolved Hide resolved
@MrAlias MrAlias mentioned this pull request Feb 20, 2024
Closed
@MrAlias MrAlias merged commit dd3b00f into open-telemetry:main Feb 20, 2024
30 checks passed
@MrAlias MrAlias deleted the add-log-noop branch February 20, 2024 16:16
@MrAlias MrAlias added this to the v1.24.0 milestone Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pellared pellared pellared approved these changes

@dmathieu dmathieu dmathieu approved these changes

@dashpole dashpole dashpole approved these changes

@XSAM XSAM XSAM approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@evantorrie evantorrie Awaiting requested review from evantorrie evantorrie is a code owner

@MadVikingGod MadVikingGod Awaiting requested review from MadVikingGod MadVikingGod is a code owner

@hanyuancheung hanyuancheung Awaiting requested review from hanyuancheung hanyuancheung is a code owner

Assignees
No one assigned
Labels
area:logs Part of OpenTelemetry logs Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
Go: Logs (GA)
Status: Done
Milestone
v1.24.0/v0.46.0
Development

Successfully merging this pull request may close these issues.

Add the log/noop package
5 participants
@MrAlias @dmathieu @dashpole @pellared @XSAM