Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

baggage: Member.String should escape only the characters that MUST be escaped #4773

Closed
pellared opened this issue Dec 20, 2023 · 0 comments · Fixed by #4775
Closed

baggage: Member.String should escape only the characters that MUST be escaped #4773

pellared opened this issue Dec 20, 2023 · 0 comments · Fixed by #4775
Assignees
@pellared
Labels
area:baggage Part of OpenTelemetry baggage enhancement New feature or request
Milestone
v1.22.0

Comments

@pellared
Copy link
Member

It is still escaping characters that are allowed by the baggage specification, right?

True, but this is spec-compliant. From: https://www.w3.org/TR/baggage/#value

Characters which are not required to be percent-encoded MAY be percent-encoded.

I still can commit myself on making an follow-up improvement to escape only the characters that MUST be escaped.
However, if you have a strong opinion, I can do it as part of this PR.

Originally posted by @pellared in #4756 (comment)
@pellared pellared self-assigned this Dec 20, 2023
@pellared pellared added area:baggage Part of OpenTelemetry baggage enhancement New feature or request labels Dec 20, 2023
This was referenced Dec 20, 2023
Merged
Merged
@MrAlias MrAlias added this to the v1.22.0 milestone Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pellared pellared

Labels
area:baggage Part of OpenTelemetry baggage enhancement New feature or request
Projects
None yet
Milestone
v1.22.0
Development

Successfully merging a pull request may close this issue.

baggage: Member.String encodes only when necessary pellared/opentelemetry-go
2 participants
@pellared @MrAlias