Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove example/fib #4723

Merged
merged 1 commit into from Nov 16, 2023
Merged

Remove example/fib #4723

merged 1 commit into from Nov 16, 2023

Conversation

pellared
Copy link
Member

Fixes #4531

@pellared pellared mentioned this pull request Nov 16, 2023
Closed
5 tasks
@codecov Codecov
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #4723 (09ab89c) into main (8ceba13) will increase coverage by 0.0%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4723   +/-   ##
=====================================
  Coverage   81.7%   81.8%           
=====================================
  Files        224     224           
  Lines      18113   18113           
=====================================
+ Hits       14815   14817    +2     
+ Misses      3002    3000    -2     
  Partials     296     296

see 1 file with indirect coverage changes

@MrAlias MrAlias added this to the v1.21.0 milestone Nov 16, 2023
@pellared
Copy link
Member Author

Merging as per agreement during the SIG meeting.

@pellared pellared merged commit a27c53b into open-telemetry:main Nov 16, 2023
25 checks passed
@pellared pellared deleted the remove-fib branch November 16, 2023 19:28
@pellared pellared mentioned this pull request Nov 16, 2023
Merged
@arukiidou arukiidou mentioned this pull request Nov 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dashpole dashpole dashpole approved these changes

@MrAlias MrAlias MrAlias approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@evantorrie evantorrie Awaiting requested review from evantorrie evantorrie is a code owner

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@MadVikingGod MadVikingGod Awaiting requested review from MadVikingGod MadVikingGod is a code owner

@hanyuancheung hanyuancheung Awaiting requested review from hanyuancheung hanyuancheung is a code owner

@dmathieu dmathieu Awaiting requested review from dmathieu dmathieu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.21.0
Development

Successfully merging this pull request may close these issues.

Create "Roll the dice" example application
3 participants
@pellared @dashpole @MrAlias