improve tracestate performance #4722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use string.Builder to directly construct the result * reduce the redundant copying during Insert * avoid using regex
xiehuc
requested review from
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4722 +/- ##
=====================================
Coverage 81.9% 81.9%
=====================================
Files 224 224
Lines 18136 18208 +72
=====================================
+ Hits 14865 14930 +65
- Misses 2984 2989 +5
- Partials 287 289 +2
|
dashpole
added
enhancement
|
The increases in allocations is concerning. The impact on GC is not captured in the benchmarks but will be when it is run on real systems. |
|
|
original benchmark result |
MrAlias
reviewed
Nov 17, 2023
|
Please address the latest CI failures. Also, please provided updated benchmark results for the applied changes. |
|
sorry forgot upload benchmark result. here it is all case are better except only |
|
@MrAlias all comment fixed, please check again, thanks |
MrAlias
reviewed
Nov 29, 2023
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
|
@MrAlias Yes，Committed the code |
|
@MrAlias Here it is |
|
i didn't put result before, because i think it is obviously better |
MrAlias
approved these changes
Nov 30, 2023
dmathieu
approved these changes
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracestate is essential logic that cannot be skipped in some scenarios that use tracestate. In the past, the implementation of tracestate did not prioritize performance, using complex regular expressions, causing its efficiency to be low. In some scenarios, too much CPU was wasted.
For example, even if it doesn't hit sampling, startServerSpan consumes 25% of the entire request CPU.
Typical server span tracestate:
Typical client span Propagation
It can be seen that the poor performance of tracestate is mainly due to regular expressions and member.String.
This CR can significantly improve Propagation by optimizing it in the following ways:
Use string.Builder to directly construct the result
Reduce the redundant copying during Insert
Avoid using regex
All unit tests pass. Benchmarks:
It can be seen that the performance has improved by about 2-3 times.