Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otlpmetrichttp otlptracehttp: Do not parse non-protobuf reponses #4719

Merged
merged 4 commits into from Nov 16, 2023

Conversation

pellared
Copy link
Member

Fixes #4717

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Merging #4719 (46d0335) into main (d968509) will decrease coverage by 0.1%.
The diff coverage is 61.1%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #4719     +/-   ##
=======================================
- Coverage   81.8%   81.8%   -0.1%     
=======================================
  Files        224     224             
  Lines      18083   18113     +30     
=======================================
+ Hits       14796   14817     +21     
- Misses      2990    3000     +10     
+ Partials     297     296      -1     
Files Coverage Δ
exporters/otlp/otlpmetric/otlpmetrichttp/client.go 80.8% <100.0%> (+0.3%) ⬆️
...pmetric/otlpmetrichttp/internal/otest/collector.go 56.7% <100.0%> (+2.0%) ⬆️
exporters/otlp/otlptrace/otlptracehttp/client.go 76.9% <100.0%> (+0.3%) ⬆️
...pmetric/otlpmetricgrpc/internal/otest/collector.go 21.8% <0.0%> (-1.1%) ⬇️

... and 1 file with indirect coverage changes

@dashpole dashpole added bug Something isn't working pkg:exporter:otlp Related to the OTLP exporter package labels Nov 16, 2023
@pellared pellared merged commit 8ceba13 into open-telemetry:main Nov 16, 2023
28 of 29 checks passed
@pellared pellared deleted the fix-4174 branch November 16, 2023 17:38
@pellared pellared mentioned this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pkg:exporter:otlp Related to the OTLP exporter package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

otlpmetrichttp otlptracehttp: Handle non-protobuf responses
3 participants