Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document PR commits preference in CONTRIBUTING.md #4704

Merged
merged 6 commits into from Nov 13, 2023
Merged

Document PR commits preference in CONTRIBUTING.md #4704

merged 6 commits into from Nov 13, 2023

Conversation

mikeblum
Copy link
Contributor

@mikeblum mikeblum commented Nov 9, 2023 •
edited by pellared

Fixes #4701

Updating CONTRIBUTING.md to explicitly document the git flow for PRs to open-telemetry/opentelemetry-go

@mikeblum
Copy link
Contributor Author

mikeblum commented Nov 9, 2023

🤔 we need to update the CHANGELOG for docs tweaks?

@mikeblum mikeblum force-pushed the GH-4701-contributing-pr-commit-pref branch from 02b85db to dc7cd82 Compare November 9, 2023 22:49
@pellared pellared added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 10, 2023
pellared
pellared reviewed Nov 10, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@mikeblum @pellared
Update CONTRIBUTING.md
657ec64 
Co-authored-by: Robert Pająk <pellared@hotmail.com>
@mikeblum mikeblum changed the title [WIP] Document PR commits preference in CONTRIBUTING.md (#4701) Document PR commits preference in CONTRIBUTING.md (#4701) Nov 12, 2023
@pellared pellared changed the title Document PR commits preference in CONTRIBUTING.md (#4701) Document PR commits preference in CONTRIBUTING.md Nov 13, 2023
@pellared pellared merged commit ca2b22b into open-telemetry:main Nov 13, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmathieu dmathieu dmathieu approved these changes

@pellared pellared pellared approved these changes

@MrAlias MrAlias Awaiting requested review from MrAlias MrAlias is a code owner

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@evantorrie evantorrie Awaiting requested review from evantorrie evantorrie is a code owner

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@MadVikingGod MadVikingGod Awaiting requested review from MadVikingGod MadVikingGod is a code owner

@hanyuancheung hanyuancheung Awaiting requested review from hanyuancheung hanyuancheung is a code owner

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document PR commits preference in CONTRIBUTING.md
3 participants
@mikeblum @dmathieu @pellared