Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otlp: Refine documentation #4695

Merged
merged 6 commits into from Nov 8, 2023
Merged

Conversation

pellared
Copy link
Member

@pellared pellared commented Nov 6, 2023

Fixes #4688

Testing:

go install golang.org/x/pkgsite/cmd/pkgsite@latest
pkgsite

@pellared pellared changed the title otlp: GoDoc comments otlp: Refine documentation Nov 6, 2023
@pellared pellared self-assigned this Nov 6, 2023
@pellared pellared added this to the v1.20.0 milestone Nov 6, 2023
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #4695 (07e2a4d) into main (0f5179f) will decrease coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #4695     +/-   ##
=======================================
- Coverage   81.8%   81.8%   -0.1%     
=======================================
  Files        225     225             
  Lines      18087   18087             
=======================================
- Hits       14798   14796      -2     
- Misses      2992    2994      +2     
  Partials     297     297             
Files Coverage Δ
exporters/otlp/otlpmetric/otlpmetricgrpc/config.go 41.8% <ø> (ø)
exporters/otlp/otlptrace/otlptracegrpc/options.go 76.4% <ø> (ø)

... and 1 file with indirect coverage changes

Copy link
Contributor

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the example cleanups a lot.

@pellared pellared merged commit 0c5ebd5 into open-telemetry:main Nov 8, 2023
25 checks passed
@pellared pellared deleted the otlp-godocs branch November 8, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Refine OTLP exporter documentation
3 participants