Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple otlpmetricgrpc and otlpmetrichttp from otlpmetric #4660

Merged
merged 4 commits into from Oct 24, 2023

Conversation

pellared
Copy link
Member

@pellared pellared commented Oct 23, 2023

I think this is the only user-facing API change that it would be good to do before making OTLP metrics exporters stable.

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #4660 (a2d938e) into main (cab95bc) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4660   +/-   ##
=====================================
  Coverage   81.3%   81.4%           
=====================================
  Files        223     225    +2     
  Lines      17721   17725    +4     
=====================================
+ Hits       14423   14429    +6     
+ Misses      2998    2996    -2     
  Partials     300     300           
Files Coverage Δ
exporters/otlp/otlpmetric/otlpmetricgrpc/client.go 91.0% <100.0%> (+0.3%) ⬆️
...tlpmetric/otlpmetricgrpc/internal/oconf/options.go 87.6% <ø> (-0.2%) ⬇️
...xporters/otlp/otlpmetric/otlpmetricgrpc/version.go 100.0% <100.0%> (ø)
exporters/otlp/otlpmetric/otlpmetrichttp/client.go 78.7% <100.0%> (ø)
...tlpmetric/otlpmetrichttp/internal/oconf/options.go 90.9% <ø> (-0.2%) ⬇️
...xporters/otlp/otlpmetric/otlpmetrichttp/version.go 100.0% <100.0%> (ø)

... and 1 file with indirect coverage changes

@pellared pellared added area:metrics Part of OpenTelemetry Metrics pkg:exporter:otlp Related to the OTLP exporter package labels Oct 23, 2023
@pellared pellared marked this pull request as ready for review October 23, 2023 10:30
@pellared pellared self-assigned this Oct 23, 2023
exporters/otlp/otlpmetric/otlpmetricgrpc/version.go Outdated Show resolved Hide resolved
exporters/otlp/otlpmetric/otlpmetrichttp/version.go Outdated Show resolved Hide resolved
@pellared pellared merged commit d18277e into open-telemetry:main Oct 24, 2023
25 checks passed
@pellared pellared deleted the fix-otlpmetric-version branch October 24, 2023 12:20
@MrAlias MrAlias added this to the v1.20.0 milestone Oct 30, 2023
This was referenced Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics pkg:exporter:otlp Related to the OTLP exporter package
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants