Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move view example into prometheus example, and deprecate /example/view #4649

Merged
merged 3 commits into from Oct 23, 2023
Merged

Move view example into prometheus example, and deprecate /example/view #4649

merged 3 commits into from Oct 23, 2023

Conversation

dashpole
Copy link
Contributor

Part of #4509

@dashpole dashpole added pkg:exporter:prometheus Related to the Prometheus exporter package pkg:example Related to an example and removed pkg:exporter:prometheus Related to the Prometheus exporter package labels Oct 20, 2023
@dashpole dashpole marked this pull request as ready for review October 20, 2023 20:53
MrAlias
MrAlias approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM outside of lint clean up

@MrAlias MrAlias merged commit cab95bc into open-telemetry:main Oct 23, 2023
25 checks passed
@MrAlias MrAlias added this to the v1.20.0 milestone Oct 30, 2023
@pellared pellared mentioned this pull request Nov 10, 2023
Merged
@MrAlias MrAlias mentioned this pull request Nov 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmathieu dmathieu dmathieu approved these changes

@pellared pellared pellared approved these changes

@MrAlias MrAlias MrAlias approved these changes

@hanyuancheung hanyuancheung hanyuancheung approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@evantorrie evantorrie Awaiting requested review from evantorrie evantorrie is a code owner

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@MadVikingGod MadVikingGod Awaiting requested review from MadVikingGod MadVikingGod is a code owner

Assignees
No one assigned
Labels
pkg:example Related to an example
Projects
Go: Metric Prometheus Exporter (GA)
Status: Done
Milestone
v1.20.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dashpole @dmathieu @pellared @MrAlias @hanyuancheung