Add summary data type to metricdata #4622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
added
enhancement
Codecov Report
@@ Coverage Diff @@
## main #4622 +/- ##
=====================================
Coverage 81.4% 81.4%
=====================================
Files 225 225
Lines 17728 17819 +91
=====================================
+ Hits 14431 14518 +87
- Misses 2998 3001 +3
- Partials 299 300 +1
|
dashpole
requested review from
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
dashpole
force-pushed
the
summary_datatype
branch
from
9b4fc8f
to
f835506
Compare
MrAlias
reviewed
Oct 18, 2023
dashpole
force-pushed
the
summary_datatype
branch
from
f426398
to
4ceffd5
Compare
dashpole
force-pushed
the
summary_datatype
branch
from
4ceffd5
to
28e98d5
Compare
MrAlias
approved these changes
Oct 23, 2023
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
MadVikingGod
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4587
This only adds the summary type to metricdata in the SDK, and does not add a corresponding AggregationSummary view aggregation. This means that the only way to create these types is to use a bridge, and they cannot otherwise be created with the OpenTelemetry SDK.