Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opencensus.NewMetricProducer returns a struct instead of the metric.Producer interface #4583

Merged
merged 4 commits into from Oct 9, 2023
Merged

opencensus.NewMetricProducer returns a struct instead of the metric.Producer interface #4583

merged 4 commits into from Oct 9, 2023

Conversation

dashpole
Copy link
Contributor

@dashpole dashpole commented Oct 3, 2023

Fixes #4570

@dashpole dashpole added pkg:bridges Related to a bridge package enhancement New feature or request labels Oct 3, 2023
@codecov
Copy link

codecov bot commented Oct 3, 2023 •
edited

Codecov Report

Merging #4583 (c97cb22) into main (56766ca) will not change coverage.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4583   +/-   ##
=====================================
  Coverage   81.3%   81.3%           
=====================================
  Files        221     221           
  Lines      17686   17686           
=====================================
  Hits       14391   14391           
  Misses      2995    2995           
  Partials     300     300
Files Coverage Δ
bridge/opencensus/metric.go 100.0% <100.0%> (ø)

pellared
pellared approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nit documentation comments.

bridge/opencensus/metric.go Outdated Show resolved Hide resolved
bridge/opencensus/metric.go Outdated Show resolved Hide resolved
dashpole and others added 2 commits October 9, 2023 09:47
@pellared pellared merged commit 68241af into open-telemetry:main Oct 9, 2023
24 checks passed
@dashpole dashpole deleted the opencensus_structs branch October 9, 2023 14:05
@dashpole dashpole mentioned this pull request Oct 9, 2023
Closed
@MrAlias MrAlias added this to the v1.20.0 milestone Oct 30, 2023
@pellared pellared mentioned this pull request Nov 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmathieu dmathieu dmathieu approved these changes

@pellared pellared pellared approved these changes

@MrAlias MrAlias Awaiting requested review from MrAlias MrAlias is a code owner

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@evantorrie evantorrie Awaiting requested review from evantorrie evantorrie is a code owner

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@MadVikingGod MadVikingGod Awaiting requested review from MadVikingGod MadVikingGod is a code owner

@hanyuancheung hanyuancheung Awaiting requested review from hanyuancheung hanyuancheung is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request pkg:bridges Related to a bridge package
Projects
No open projects
Go: Metric OpenCensus Bridge (GA)
Status: Done
Milestone
v1.20.0
Development

Successfully merging this pull request may close these issues.

OpenCensus bridge should return structs
4 participants
@dashpole @dmathieu @pellared @MrAlias