Opencensus bridge: migrate from README to Go docs #4561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
force-pushed
the
opencensus_docs
branch
from
759d2d5
to
85ef29a
Compare
dashpole
requested review from
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
pellared
reviewed
Sep 27, 2023
Co-authored-by: Robert Pająk <pellared@hotmail.com>
MrAlias
approved these changes
Sep 27, 2023
pellared
approved these changes
Sep 27, 2023
dmathieu
approved these changes
Sep 28, 2023
pellared
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was inspired by what I learned from @pellared.
This migrates from a README to godocs, and adds an example_test.go
It removes some content that probably isn't relevant for users about making context propagation work between the libraries.
It adds a section on the limitations of the metric bridge.