Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdk/metric: Update package example #4540

Merged
merged 3 commits into from Sep 22, 2023
Merged

sdk/metric: Update package example #4540

merged 3 commits into from Sep 22, 2023

Conversation

pellared
Copy link
Member

@pellared pellared commented Sep 21, 2023 •
edited

Main changes:

  1. Update comment. The [package] comments are not working in "regular" comments.
  2. Move "defer cleanup" before setting the global. I think it is a good practice to defer cleanup ASAP.
  3. I think there is no need to add reference to resource package.

@pellared pellared added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 21, 2023
@pellared pellared marked this pull request as ready for review September 21, 2023 15:05
@pellared pellared mentioned this pull request Sep 21, 2023
Merged
dmathieu
dmathieu reviewed Sep 21, 2023
View reviewed changes
sdk/metric/example_test.go Outdated Show resolved Hide resolved
sdk/metric/example_test.go Outdated Show resolved Hide resolved
@pellared pellared merged commit 10b9f90 into open-telemetry:main Sep 22, 2023
24 checks passed
@MrAlias MrAlias added this to the v1.19.0/v0.42.0 milestone Sep 28, 2023
@pellared pellared deleted the fix-sdk-metric-package-example branch November 17, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmathieu dmathieu dmathieu approved these changes

@MrAlias MrAlias MrAlias approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@evantorrie evantorrie Awaiting requested review from evantorrie evantorrie is a code owner

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@MadVikingGod MadVikingGod Awaiting requested review from MadVikingGod MadVikingGod is a code owner

@hanyuancheung hanyuancheung Awaiting requested review from hanyuancheung hanyuancheung is a code owner

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v1.19.0/v0.42.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pellared @dmathieu @MrAlias