Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade gopkg.io/yaml from v2 to v3 in schema #4535

Merged
merged 1 commit into from Sep 21, 2023

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Sep 19, 2023

Resolve #4533

Based on docs, internal code review, and testing, KnownFields is the equivalent of how we are currently using SetStrict.

@MrAlias MrAlias added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 19, 2023
@MrAlias MrAlias marked this pull request as ready for review September 19, 2023 19:57
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #4535 (dc9375e) into main (bf54101) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #4535     +/-   ##
=======================================
- Coverage   81.3%   81.3%   -0.1%     
=======================================
  Files        220     220             
  Lines      17678   17679      +1     
=======================================
- Hits       14386   14384      -2     
- Misses      2992    2994      +2     
- Partials     300     301      +1     
Files Changed Coverage
schema/v1.0/parser.go 100.0%
schema/v1.1/parser.go 100.0%

@pellared pellared merged commit fd8eff8 into open-telemetry:main Sep 21, 2023
24 checks passed
@MrAlias MrAlias deleted the up-yaml-v3-schema branch September 21, 2023 14:03
MrAlias added a commit to MrAlias/opentelemetry-go that referenced this pull request Sep 21, 2023
@MrAlias MrAlias added this to the v1.19.0/v0.42.0 milestone Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

schema: upgrade yaml package to v3
4 participants