Revert "Collector example: add metrics and use official port (#4466)" #4487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lemetry#4466)" This reverts commit 6eedabf.
MrAlias
requested review from
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
10 tasks
Codecov Report
@@ Coverage Diff @@
## main #4487 +/- ##
=====================================
Coverage 81.3% 81.3%
=====================================
Files 220 220
Lines 17670 17670
=====================================
+ Hits 14378 14380 +2
+ Misses 2992 2990 -2
Partials 300 300 📢 Thoughts on this report? Let us know!. |
dmathieu
approved these changes
Sep 8, 2023
MadVikingGod
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #4466.
This addition made the stable module
go.opentelemetry.io/otel/example/otel-collectordepends on the followiung unstable modulesgo.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpcgo.opentelemetry.io/otel/sdk/metricgo.opentelemetry.io/otel/exporters/otlp/otlpmetricThis can be added back in when those modules become stable.