Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the expoHistogramValues type #4450

Merged
merged 1 commit into from Aug 17, 2023

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Aug 16, 2023

Cleanup the exponential histogram aggregate.

The only use of the expoHistogramValues is it being embedded in the expoHistogram. Just explicitly define the expoHistogramValues fields for expoHistogram given that is their only use.

The types only use is being embedded in the expoHistogram. Just
explicitly define the fields for the expoHistogram given that is their
only use.
@MrAlias MrAlias added pkg:SDK Related to an SDK package area:metrics Part of OpenTelemetry Metrics Skip Changelog PRs that do not require a CHANGELOG.md entry labels Aug 16, 2023
@MrAlias MrAlias added this to the v1.17.0/v0.40.0 milestone Aug 16, 2023
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #4450 (ae5ee59) into main (a5ff7af) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #4450     +/-   ##
=======================================
- Coverage   78.9%   78.9%   -0.1%     
=======================================
  Files        254     254             
  Lines      20650   20642      -8     
=======================================
- Hits       16307   16297     -10     
- Misses      3998    4000      +2     
  Partials     345     345             
Files Changed Coverage Δ
...metric/internal/aggregate/exponential_histogram.go 96.1% <100.0%> (-0.2%) ⬇️

... and 1 file with indirect coverage changes

@MadVikingGod MadVikingGod merged commit 9d9b71f into open-telemetry:main Aug 17, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants