Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support default histogram selection in OTLP exporter #4437

Merged
merged 5 commits into from Aug 14, 2023

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Aug 11, 2023

Resolve #4422

If a user sets the OTEL_EXPORTER_OTLP_METRICS_DEFAULT_HISTOGRAM_AGGREGATION to base2_exponential_bucket_histogram (case-insensitive) the default base-2 exponential histogram should be used for the exporter selector in both OTLP metric exporters.

@MrAlias MrAlias added the pkg:exporter:otlp Related to the OTLP exporter package label Aug 11, 2023
@MrAlias MrAlias added this to the v1.17.0/v0.40.0 milestone Aug 11, 2023
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #4437 (5734939) into main (af1d928) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4437   +/-   ##
=====================================
  Coverage   78.8%   78.8%           
=====================================
  Files        253     253           
  Lines      20630   20668   +38     
=====================================
+ Hits       16267   16307   +40     
+ Misses      4014    4012    -2     
  Partials     349     349           
Files Changed Coverage Δ
...pmetric/otlpmetricgrpc/internal/oconf/envconfig.go 93.1% <100.0%> (+1.1%) ⬆️
...pmetric/otlpmetrichttp/internal/oconf/envconfig.go 93.1% <100.0%> (+1.1%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Contributor

@evantorrie evantorrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I haven't been reviewing lately, but see that we're using gotmpl for this repetitive code between otlpmetric{grpc,http}. Looks like this is the outcome of #3846.

I think many of the language SDKs have similar issues.

@MrAlias MrAlias merged commit 199dc34 into open-telemetry:main Aug 14, 2023
22 checks passed
@MrAlias MrAlias deleted the otlp-default-hist branch August 14, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:exporter:otlp Related to the OTLP exporter package
Projects
None yet
4 participants