Expand the set of units supported by the prometheus exporter #4374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
requested review from
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4374 +/- ##
=====================================
Coverage 83.4% 83.4%
=====================================
Files 184 184
Lines 14380 14380
=====================================
Hits 11997 11997
Misses 2155 2155
Partials 228 228
|
MrAlias
reviewed
Jul 26, 2023
duplicate unit suffixes
MrAlias
approved these changes
Jul 27, 2023
|
Opportunistic question: Should we add some doc comments to https://pkg.go.dev/go.opentelemetry.io/otel/metric#WithUnit that we recommend using UCUM units? Related to #4374 (comment) |
Doing so in a separate PR sounds good to me. |
dmitryax
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Aug 1, 2023
**Description:** Discovered during open-telemetry/opentelemetry-go#4374 (review). `B` means `bel` in UCUM, so MB is `megabel`, for example. `$` is also not UCUM. https://ucum.org/ucum#section-Alphabetic-Index-By-Symbol
pellared
approved these changes
Aug 2, 2023
hanyuancheung
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4372.
We currently have a very small set of units we recognize. Expand it so that we can cover more cases, such as the one pointed out in the issue.
Change the tests to use seconds instead of milliseconds, as we want to ensure that case works correctly.
The set of units is copied from https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/pkg/translator/prometheus/normalize_name.go#L19