Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle 2xx as success for OTLP HTTP trace and metric exporters #4365

Merged
merged 11 commits into from Aug 7, 2023
Merged

Handle 2xx as success for OTLP HTTP trace and metric exporters #4365

merged 11 commits into from Aug 7, 2023

Conversation

dmathieu
Copy link
Member

Closes #4363.

pellared
pellared reviewed Jul 26, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 26, 2023 •
edited

Codecov Report

Merging #4365 (46afdb1) into main (b221025) will decrease coverage by 0.1%.
The diff coverage is 81.8%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #4365     +/-   ##
=======================================
- Coverage   83.5%   83.5%   -0.1%     
=======================================
  Files        229     229             
  Lines      18653   18679     +26     
=======================================
+ Hits       15584   15605     +21     
- Misses      2751    2755      +4     
- Partials     318     319      +1
Files Changed Coverage Δ
...orters/otlp/otlpmetric/internal/otest/collector.go 6.8% <0.0%> (-0.2%) ⬇️
exporters/otlp/otlpmetric/internal/otest/client.go 96.8% <95.4%> (-0.3%) ⬇️
exporters/otlp/otlpmetric/otlpmetrichttp/client.go 78.7% <100.0%> (ø)
exporters/otlp/otlptrace/otlptracehttp/client.go 77.6% <100.0%> (ø)

@pellared
Copy link
Member

Please update the PR title and description.

@dmathieu dmathieu changed the title Handle 204 as success for HTTP traces and metric exporters Handle 2xx as success for HTTP traces and metric exporters Jul 26, 2023
@MrAlias MrAlias changed the title Handle 2xx as success for HTTP traces and metric exporters Handle 2xx as success for OTLP HTTP trace and metric exporters Jul 27, 2023
@MrAlias MrAlias merged commit 10099bb into open-telemetry:main Aug 7, 2023
21 of 22 checks passed
@MrAlias MrAlias added this to the v1.17.0/v0.40.0 milestone Aug 7, 2023
@MrAlias MrAlias mentioned this pull request Aug 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dashpole dashpole dashpole approved these changes

@pellared pellared pellared approved these changes

@MrAlias MrAlias MrAlias approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@evantorrie evantorrie Awaiting requested review from evantorrie evantorrie is a code owner

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@MadVikingGod MadVikingGod Awaiting requested review from MadVikingGod MadVikingGod is a code owner

@hanyuancheung hanyuancheung Awaiting requested review from hanyuancheung hanyuancheung is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.17.0/v0.40.0
Development

Successfully merging this pull request may close these issues.

Exporting fails if a 204 No Content is returned
4 participants
@dmathieu @pellared @dashpole @MrAlias