Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add semconv/v1.21.0 #4362

Merged
merged 6 commits into from Jul 26, 2023
Merged

Add semconv/v1.21.0 #4362

merged 6 commits into from Jul 26, 2023

Conversation

pellared
Copy link
Member

@pellared pellared commented Jul 25, 2023

Fixes #4355

I had to make a little change in semconvgen to make the generation working open-telemetry/opentelemetry-go-build-tools#374 as the folder were the YAML files changed.

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #4362 (da596b0) into main (d5d6318) will increase coverage by 0.0%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4362   +/-   ##
=====================================
  Coverage   83.4%   83.4%           
=====================================
  Files        184     184           
  Lines      14383   14383           
=====================================
+ Hits       12002   12004    +2     
+ Misses      2153    2151    -2     
  Partials     228     228           

see 1 file with indirect coverage changes

Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you given a look to upgrading all use of semconv in this repo and contrib to these changes? Are we missing any thing in the generation to accomplish this?

Are you planning to upgrade semconv in follow PRs?

@pellared
Copy link
Member Author

pellared commented Jul 26, 2023

@MrAlias

Have you given a look to upgrading all use of semconv in this repo and contrib to these changes? Are we missing any thing in the generation to accomplish this?

I have not found anything missing. Is there anything special that I should double-check?

Are you planning to upgrade semconv in follow PRs?

I created a separate issue #4364 to address this.

@MrAlias
Copy link
Contributor

MrAlias commented Jul 26, 2023

Is there anything special that I should double-check?

Nothing seems obvious to me in glancing over this, but I haven't tried the upgrade. I was just wondering given the shuffle upstream and the fact that we don't generate everything if we missed something.

If you've already taken a look at the upgrade that's good enough for me.

@pellared pellared merged commit 830fae8 into open-telemetry:main Jul 26, 2023
22 checks passed
@pellared pellared deleted the semconv-v1.21.0 branch July 26, 2023 15:09
@MrAlias MrAlias added this to the v1.17.0 milestone Aug 3, 2023
@mehdihadeli
Copy link

mehdihadeli commented Sep 26, 2023

Hi,
Seems httpconv doesn't exist in v1.21.0, but it exists in v1.20.0, and It creates some incompatibility in our apps and for using httpconv features we have to add a reference to old v1.20.0 version beside of v1.21.0

@pellared
Copy link
Member Author

pellared commented Sep 26, 2023

Hi, Seems httpconv doesn't exist in v1.21.0, but it exists in v1.20.0, and It creates some incompatibility in our apps and for using httpconv features we have to add a reference to old v1.20.0 version beside of v1.21.0

Hi @mehdihadeli

See:

- Starting from `v1.21.0` of semantic conventions, `go.opentelemetry.io/otel/semconv/{version}/httpconv` and `go.opentelemetry.io/otel/semconv/{version}/netconv` packages will no longer be published. (#4145)

It was as designed and planned as part of #4081

If you want you can copy-paste (or generate the code like we do e.g. here) the code from https://github.com/open-telemetry/opentelemetry-go-contrib/tree/main/internal/shared/semconvutil

@mehdihadeli
Copy link

mehdihadeli commented Sep 26, 2023

Can I use opentelemetry-go-contrib package and semconvutil and httpconv directly, instead of creating it manually myself? It is internal and it is not possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate v1.21.0 semantic conventions
4 participants