Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otlpmetric: Fix serialization of time.Time zero values #4271

Merged
merged 3 commits into from
Jun 30, 2023

Conversation

pellared
Copy link
Member

@pellared pellared commented Jun 29, 2023

Fixes #4268

Remarks:
I hope that adding a test case for one field is good enough (and that I do not need to add test cases for all possible fields).

pellared added 3 commits June 29, 2023 13:45

Verified

This commit was signed with the committer’s verified signature.
pellared Robert Pająk

Verified

This commit was signed with the committer’s verified signature.
pellared Robert Pająk

Verified

This commit was signed with the committer’s verified signature.
pellared Robert Pająk
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #4271 (03df5e7) into main (4570292) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #4271     +/-   ##
=======================================
- Coverage   83.6%   83.5%   -0.1%     
=======================================
  Files        181     181             
  Lines      14184   14189      +5     
=======================================
+ Hits       11860   11861      +1     
- Misses      2096    2100      +4     
  Partials     228     228             
Impacted Files Coverage Δ
...s/otlp/otlpmetric/internal/transform/metricdata.go 100.0% <100.0%> (ø)

... and 1 file with indirect coverage changes

@pellared pellared marked this pull request as ready for review June 29, 2023 12:02
@pellared
Copy link
Member Author

CC @anil181

@pellared pellared changed the title otlpmetric: Fix serialization of time.Time zero values otlpmetric: Fix serialization of time.Time zero fields Jun 29, 2023
@pellared pellared changed the title otlpmetric: Fix serialization of time.Time zero fields otlpmetric: Fix serialization of time.Time zero values Jun 29, 2023
@pellared pellared merged commit d575693 into open-telemetry:main Jun 30, 2023
@MrAlias MrAlias added this to the v1.17.0 milestone Aug 3, 2023
@pellared pellared deleted the 4268 branch November 17, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

otlpmetric: StartTimeUnixNano for Gauge metric points is always set to "11651379494838206464"
4 participants