Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdk/metric: Reader factories return structs #4244

Merged
merged 3 commits into from Jun 22, 2023
Merged

sdk/metric: Reader factories return structs #4244

merged 3 commits into from Jun 22, 2023

Conversation

pellared
Copy link
Member

Fixes #4243

@pellared pellared added pkg:SDK Related to an SDK package area:metrics Part of OpenTelemetry Metrics labels Jun 21, 2023
@codecov
Copy link

codecov bot commented Jun 21, 2023 •
edited

Codecov Report

Merging #4244 (e3467a6) into main (ca2aa83) will increase coverage by 0.0%.
The diff coverage is 95.4%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4244   +/-   ##
=====================================
  Coverage   83.5%   83.5%           
=====================================
  Files        181     181           
  Lines      14161   14161           
=====================================
+ Hits       11825   11827    +2     
+ Misses      2109    2107    -2     
  Partials     227     227
Impacted Files Coverage Δ
sdk/metric/periodic_reader.go 91.8% <92.3%> (ø)
sdk/metric/manual_reader.go 85.0% <100.0%> (ø)

... and 1 file with indirect coverage changes

dmathieu
dmathieu reviewed Jun 21, 2023
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@pellared pellared requested a review from dmathieu June 21, 2023 08:29
@pellared pellared merged commit 6b262b4 into open-telemetry:main Jun 22, 2023
22 checks passed
@pellared pellared deleted the ret-reader-structs branch June 22, 2023 07:09
@pellared pellared mentioned this pull request Jul 27, 2023
Merged
@MrAlias MrAlias mentioned this pull request Aug 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmathieu dmathieu dmathieu approved these changes

@dashpole dashpole dashpole approved these changes

@MrAlias MrAlias Awaiting requested review from MrAlias MrAlias is a code owner

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@evantorrie evantorrie Awaiting requested review from evantorrie evantorrie is a code owner

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@MadVikingGod MadVikingGod Awaiting requested review from MadVikingGod MadVikingGod is a code owner

@hanyuancheung hanyuancheung Awaiting requested review from hanyuancheung hanyuancheung is a code owner

Assignees
No one assigned
Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package
Projects
No open projects
Go: Metric SDK (GA)
Status: Done
Milestone
v1.17.0/v0.40.0
Development

Successfully merging this pull request may close these issues.

sdk/metric: NewManualReader and NewPeriodicReader should return structs
4 participants
@pellared @dmathieu @dashpole @MrAlias