Count the Collect duration towards the PeriodicReader timeout, and document the behavior #4221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmathieu
requested review from
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared and
hanyuancheung
as code owners
dmathieu
force-pushed
the
periodic-reader-timeout
branch
from
14b0ec8
to
dc0ed15
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4221 +/- ##
=======================================
- Coverage 83.5% 83.5% -0.1%
=======================================
Files 181 181
Lines 14161 14162 +1
=======================================
- Hits 11829 11828 -1
- Misses 2105 2107 +2
Partials 227 227
|
dmathieu
force-pushed
the
periodic-reader-timeout
branch
3 times, most recently
from
93676b1
to
b6e5f6b
Compare
dmathieu
force-pushed
the
periodic-reader-timeout
branch
from
b6e5f6b
to
9963a19
Compare
dmathieu
commented
Jun 15, 2023
pellared
approved these changes
Jun 21, 2023
pellared
added
pkg:SDK
dmathieu
force-pushed
the
periodic-reader-timeout
branch
from
235e556
to
83c17db
Compare
MadVikingGod
approved these changes
Jun 23, 2023
hanyuancheung
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As documented in #4166, this changes the way we set the collect/export timeout in the PeriodicReader, so that timeout includes both collection and export, and not only export.
This also documents the timeout behavior.
See #4166.