Exponential Histogram Datatypes #4165
Merged
+407
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadVikingGod
requested review from
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
pellared,
hanyuancheung and
dmathieu
as code owners
MrAlias
reviewed
Jun 1, 2023
Co-authored-by: Robert Pająk <pellared@hotmail.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4165 +/- ##
=======================================
+ Coverage 83.3% 83.4% +0.1%
=======================================
Files 181 181
Lines 13986 14116 +130
=======================================
+ Hits 11657 11786 +129
- Misses 2102 2103 +1
Partials 227 227
|
pellared
approved these changes
Jun 5, 2023
3 tasks
MrAlias
approved these changes
Jun 9, 2023
pellared
approved these changes
Jun 12, 2023
hanyuancheung
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces the Exponential Histogram datatype in the Metrics SDK. This is the serializable format that exporters will use.
This patch does not do the follow, and will this functionality be added in follow on patches:
EDIT: OTel Spec for reference: https://github.com/open-telemetry/opentelemetry-specification/blob/v1.21.0/specification/metrics/data-model.md#exponentialhistogram