Return noop meters once the provider has been shutdown #4154
+44
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmathieu
requested review from
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared and
hanyuancheung
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4154 +/- ##
=======================================
- Coverage 83.4% 83.3% -0.1%
=======================================
Files 181 181
Lines 13928 13940 +12
=======================================
+ Hits 11617 11625 +8
- Misses 2090 2094 +4
Partials 221 221
|
MrAlias
added
pkg:SDK
MrAlias
reviewed
May 31, 2023
MrAlias
approved these changes
May 31, 2023
pellared
approved these changes
May 31, 2023
pmcollins
reviewed
May 31, 2023
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
pellared
approved these changes
Jun 1, 2023
hanyuancheung
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4148.