Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Histogram Extrema and Sum to be generic #3870

Merged
merged 11 commits into from
Mar 29, 2023

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Mar 14, 2023

Resolve #3855

@MrAlias MrAlias added pkg:SDK Related to an SDK package area:metrics Part of OpenTelemetry Metrics labels Mar 14, 2023
@MrAlias MrAlias added this to the Metric SDK v0.38.0 milestone Mar 14, 2023
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #3870 (8fe16c3) into main (63a0f51) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3870     +/-   ##
=======================================
- Coverage   81.7%   81.7%   -0.1%     
=======================================
  Files        170     170             
  Lines      12949   12948      -1     
=======================================
- Hits       10588   10587      -1     
  Misses      2138    2138             
  Partials     223     223             
Impacted Files Coverage Δ
...s/otlp/otlpmetric/internal/transform/metricdata.go 100.0% <100.0%> (ø)
exporters/prometheus/exporter.go 83.7% <100.0%> (ø)
sdk/metric/internal/histogram.go 100.0% <100.0%> (ø)
sdk/metric/metricdata/data.go 57.1% <100.0%> (ø)
sdk/metric/metricdata/metricdatatest/assertion.go 87.3% <100.0%> (+0.2%) ⬆️
...dk/metric/metricdata/metricdatatest/comparisons.go 88.2% <100.0%> (ø)

... and 2 files with indirect coverage changes

@MrAlias MrAlias closed this Mar 29, 2023
@MrAlias MrAlias reopened this Mar 29, 2023
@MrAlias MrAlias merged commit f4a9d78 into open-telemetry:main Mar 29, 2023
20 checks passed
@MrAlias MrAlias deleted the exemplar-generic branch March 29, 2023 18:24
@MrAlias MrAlias mentioned this pull request Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Make extrema a generic over int64 and float64
3 participants