Mark the span as error when the HTTP transporter fails #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xabier Larrakoetxea <me@slok.dev>
slok
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
MadVikingGod,
MrAlias,
paivagustavo,
pellared and
XSAM
as code owners
Signed-off-by: Xabier Larrakoetxea <me@slok.dev>
dashpole
approved these changes
Aug 10, 2021
Codecov Report
@@ Coverage Diff @@
## main #950 +/- ##
=======================================
+ Coverage 75.4% 75.6% +0.1%
=======================================
Files 69 69
Lines 4458 4460 +2
=======================================
+ Hits 3363 3372 +9
+ Misses 952 946 -6
+ Partials 143 142 -1
|
MrAlias
reviewed
Aug 10, 2021
Signed-off-by: Xabier Larrakoetxea <me@slok.dev>
MrAlias
approved these changes
Aug 11, 2021
|
This looks ready to merge outside of fixing the lint issues: |
Aneurysm9
approved these changes
Aug 11, 2021
Signed-off-by: Xabier Larrakoetxea <me@slok.dev>
|
Done! |
pellared
approved these changes
Aug 12, 2021
…on some test parts Signed-off-by: Xabier Larrakoetxea <me@slok.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! 👋
Currently, the HTTP Transporter is recording the errors, however, is not marking the span as an error, and this is misleading. For example, if the Request fails because there is nobody listening to our client calls we would not see that the request has failed easily (unless an upper layer records the error):
Before:
After the fix: