Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmarks for the prometheus bridge #5364

Merged
merged 6 commits into from Apr 9, 2024

Conversation

dashpole
Copy link
Contributor

@dashpole dashpole commented Apr 7, 2024

I wanted to get some rough numbers for how much overhead the prometheus bridge + OTLP exporter adds to pure Prometheus instrumentation, and also compare that with the Prometheus receiver vs OTLP receiver in the collector.

They aren't the best benchmarks (I used things like top and docker stats to measure), but the results broadly show what I expected, which is that is is much less expensive to do the translation client-side with the bridge, than server-side with the Prometheus Receiver.

My sample code: prometheus/client_golang@main...dashpole:client_golang:benchmarking

cc @gouthamve @logicalhan

@dashpole dashpole requested a review from a team as a code owner April 7, 2024 16:20
bridges/prometheus/BENCHMARKS.md Outdated Show resolved Hide resolved
bridges/prometheus/BENCHMARKS.md Show resolved Hide resolved
@dashpole dashpole added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Apr 8, 2024
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.9%. Comparing base (b343370) to head (daecb73).

❗ Current head daecb73 differs from pull request most recent head 9b9d10a. Consider uploading reports for the commit 9b9d10a to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #5364   +/-   ##
=====================================
  Coverage   61.8%   61.9%           
=====================================
  Files        186     186           
  Lines      11388   11388           
=====================================
+ Hits        7049    7051    +2     
+ Misses      4137    4136    -1     
+ Partials     202     201    -1     

see 1 file with indirect coverage changes

@pellared pellared requested a review from dmathieu April 9, 2024 05:52
@dashpole dashpole merged commit 7a9e861 into open-telemetry:main Apr 9, 2024
21 checks passed
@dashpole dashpole deleted the bridge_benchmarks branch April 9, 2024 13:01
@MrAlias MrAlias added this to the v1.26.0 milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants