New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
otelslog: Add example #5355
Merged
Merged
otelslog: Add example #5355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pellared
added
the
Skip Changelog
Allow PR to succeed without requiring an addition to the CHANGELOG
label
Apr 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main open-telemetry/opentelemetry-go-contrib#5355 +/- ##
=======================================
- Coverage 61.9% 61.8% -0.1%
=======================================
Files 186 186
Lines 11388 11388
=======================================
- Hits 7051 7049 -2
- Misses 4136 4137 +1
- Partials 201 202 +1 |
dmathieu
approved these changes
Apr 3, 2024
dashpole
reviewed
Apr 3, 2024
Co-authored-by: David Ashpole <dashpole@google.com>
dashpole
reviewed
Apr 3, 2024
Should the example show how to call slog.SetDefault? |
I did not want to do that as many people find global logger as an anti-pattern. |
dashpole
approved these changes
Apr 3, 2024
XSAM
approved these changes
Apr 3, 2024
MrAlias
approved these changes
Apr 3, 2024
zailic
pushed a commit
to zailic/opentelemetry-go-contrib
that referenced
this pull request
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bridge: slog
Related to the slog bridge
Skip Changelog
Allow PR to succeed without requiring an addition to the CHANGELOG
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards open-telemetry/opentelemetry.io#4461