Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otelslog: Add example #5355

Merged
merged 4 commits into from Apr 3, 2024
Merged

otelslog: Add example #5355

merged 4 commits into from Apr 3, 2024

Conversation

pellared
Copy link
Member

@pellared pellared commented Apr 3, 2024

@pellared pellared requested a review from a team as a code owner April 3, 2024 06:39
@pellared pellared added the bridge: slog Related to the slog bridge label Apr 3, 2024
@pellared pellared self-assigned this Apr 3, 2024
@pellared pellared added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Apr 3, 2024
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.8%. Comparing base (d15fe4f) to head (79e41d6).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   open-telemetry/opentelemetry-go-contrib#5355     +/-   ##
=======================================
- Coverage   61.9%   61.8%   -0.1%     
=======================================
  Files        186     186             
  Lines      11388   11388             
=======================================
- Hits        7051    7049      -2     
- Misses      4136    4137      +1     
- Partials     201     202      +1     

see 1 file with indirect coverage changes

pellared and others added 2 commits April 3, 2024 16:38
Co-authored-by: David Ashpole <dashpole@google.com>
@dashpole
Copy link
Contributor

dashpole commented Apr 3, 2024

Should the example show how to call slog.SetDefault?

@pellared
Copy link
Member Author

pellared commented Apr 3, 2024

Should the example show how to call slog.SetDefault?

I did not want to do that as many people find global logger as an anti-pattern.

@pellared pellared merged commit 17fc3a3 into open-telemetry:main Apr 3, 2024
23 checks passed
@pellared pellared deleted the slog-example branch April 3, 2024 19:23
zailic pushed a commit to zailic/opentelemetry-go-contrib that referenced this pull request Apr 4, 2024
@MrAlias MrAlias added this to the v1.25.0 milestone Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bridge: slog Related to the slog bridge Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants