Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.23.0/v0.48.0/v0.17.0/v0.3.0 #4893

Merged
merged 11 commits into from Feb 6, 2024

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Feb 6, 2024

Added

Changed

  • The fallback options in go.opentelemetry.io/contrib/exporters/autoexport now accept factory functions. (feat(autoexport): change WithFallback options signatures #4891)
    • WithFallbackMetricReader(metric.Reader) MetricOption is replaced with func WithFallbackMetricReader(func(context.Context) (metric.Reader, error)) MetricOption.
    • WithFallbackSpanExporter(trace.SpanExporter) SpanOption is replaced with WithFallbackSpanExporter(func(context.Context) (trace.SpanExporter, error)) SpanOption.

Deprecated

  • The RequestCount, RequestContentLength, ResponseContentLength, ServerLatency constants in go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp are deprecated. (otelhttp: client metrics #4707)

Fixed

@MrAlias MrAlias added this to the v0.48.0 milestone Feb 6, 2024
@MrAlias
Copy link
Contributor Author

MrAlias commented Feb 6, 2024

The only code modification outside of the normal (mostly automated) release process is the changes to config tests to handle the merged conflicting resource.

@MrAlias MrAlias marked this pull request as ready for review February 6, 2024 17:16
@MrAlias

This comment was marked as outdated.

@dashpole
Copy link
Contributor

dashpole commented Feb 6, 2024

Do we need any semconv bumps in detectors before the release? Or did we not introduce any new semconv versions this release?

@MrAlias
Copy link
Contributor Author

MrAlias commented Feb 6, 2024

Do we need any semconv bumps in detectors before the release? Or did we not introduce any new semconv versions this release?

We did not introduce new semconv versions in the v1.23.0 otel release.

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@de64a47). Click here to learn what that means.

❗ Current head e161c7b differs from pull request most recent head 530cc90. Consider uploading reports for the commit 530cc90 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff           @@
##             main   #4893   +/-   ##
======================================
  Coverage        ?   80.3%           
======================================
  Files           ?     151           
  Lines           ?   10209           
  Branches        ?       0           
======================================
  Hits            ?    8201           
  Misses          ?    1854           
  Partials        ?     154           
Files Coverage Δ
...github.com/aws/aws-lambda-go/otellambda/version.go 60.0% <100.0%> (ø)
...on/github.com/aws/aws-sdk-go-v2/otelaws/version.go 60.0% <100.0%> (ø)
...hub.com/emicklei/go-restful/otelrestful/version.go 60.0% <100.0%> (ø)
...tation/github.com/gin-gonic/gin/otelgin/version.go 60.0% <100.0%> (ø)
...entation/github.com/gorilla/mux/otelmux/version.go 60.0% <100.0%> (ø)
...ation/github.com/labstack/echo/otelecho/version.go 60.0% <100.0%> (ø)
...ntation/google.golang.org/grpc/otelgrpc/version.go 100.0% <100.0%> (ø)
...ntation/gopkg.in/macaron.v1/otelmacaron/version.go 60.0% <100.0%> (ø)
...tation/net/http/httptrace/otelhttptrace/version.go 60.0% <100.0%> (ø)
instrumentation/net/http/otelhttp/test/version.go 60.0% <100.0%> (ø)
... and 24 more

@MrAlias MrAlias merged commit 087fdd4 into open-telemetry:main Feb 6, 2024
20 checks passed
@MrAlias MrAlias deleted the release-v1.23.0 branch February 6, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants