Remove unused portions of the internal semconvutil #4878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadVikingGod
requested review from
Aneurysm9,
dmathieu,
a team and
hanyuancheung
as code owners
MadVikingGod
added
the
Skip Changelog
pellared
approved these changes
Jan 31, 2024
MrAlias
approved these changes
Jan 31, 2024
dashpole
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the semconvutil package is templated and internal (not shared), we are free to remove any code that isn't used by any of our telemetry without breaking on update.
This code removes A number of public functions, tests of these functions, and supporting code that are not used by any of our instrumentation.
HTTPRequestHeaderHTTPResponseHeaderNetClientNetServer