config: NewSDK can return valid MeterProvider #4804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeboten
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4804 +/- ##
=======================================
+ Coverage 61.8% 62.1% +0.2%
=======================================
Files 186 186
Lines 11388 11527 +139
=======================================
+ Hits 7049 7166 +117
- Misses 4137 4149 +12
- Partials 202 212 +10
|
codeboten
force-pushed
the
codeboten/add-meter-provider-sdk
branch
2 times, most recently
from
905a8ac
to
792c424
Compare
codeboten
requested review from
MadVikingGod,
pellared and
a team
as code owners
codeboten
changed the title
MadVikingGod
approved these changes
Feb 15, 2024
|
@codeboten Can you please update the branch (resolve conflicts)? I will do my best to review the PR this week. |
pellared
reviewed
Feb 21, 2024
hanyuancheung
approved these changes
Feb 26, 2024
|
|
codeboten
force-pushed
the
codeboten/add-meter-provider-sdk
branch
from
2d2a5b1
to
8e92da2
Compare
dashpole
approved these changes
Mar 4, 2024
codeboten
force-pushed
the
codeboten/add-meter-provider-sdk
branch
from
8e92da2
to
5508d92
Compare
pellared
approved these changes
Mar 5, 2024
Comment on lines
+226
to
+228
| // TODO: add support for constant label filter | ||
| // otelprom.WithResourceAsConstantLabels(attribute.NewDenyKeysFilter()), | ||
| // ) |
There was a problem hiding this comment.
Can you create an issue for tracking and reference it here?
Follow up to open-telemetry#4741, does the same but for metric signal. Fixes open-telemetry#4371 Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
codeboten
force-pushed
the
codeboten/add-meter-provider-sdk
branch
from
5508d92
to
997c85e
Compare
scorpionknifes
added a commit
to scorpionknifes/opentelemetry-go-contrib
that referenced
this pull request
Apr 24, 2024
scorpionknifes
pushed a commit
to scorpionknifes/opentelemetry-go-contrib
that referenced
this pull request
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #4741, does the same but for metric signal.
Fixes #4371
Will rebase once 4741 is merged