config: prepare package for release #4541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeboten
force-pushed
the
codeboten/config-release
branch
from
20ead20
to
eb3f372
Compare
Codecov Report
@@ Coverage Diff @@
## main #4541 +/- ##
=====================================
Coverage 80.8% 80.8%
=====================================
Files 150 150
Lines 10371 10371
=====================================
Hits 8387 8387
Misses 1840 1840
Partials 144 144
|
This PR does the following: - adds a section to versions.yaml, please review that the new section makes sense, it didn't seem to fit in any of the other groups. - adds doc.go - adds example Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten
force-pushed
the
codeboten/config-release
branch
from
eb3f372
to
3e4eee5
Compare
|
@pellared does this type of change require a changelog? Happy to add one, I just wasn't sure :) |
codeboten
changed the title
pellared
added
the
Skip Changelog
|
pellared
reviewed
Nov 9, 2023
I added a "Skip Changelog" label. |
Signed-off-by: Alex Boten <aboten@lightstep.com>
The readme has been removed, and todo's added in config.go. PTAL |
pellared
approved these changes
Nov 9, 2023
PS. I was thinking about adding TODO to |
MadVikingGod
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
Fixes #4415