otelgrpc: Fix stats handlers to honor WithMessageEvents option #4536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
fatsheep9146
requested review from
dashpole,
hanyuancheung and
a team
as code owners
fatsheep9146
changed the title
withMessageEvents
Codecov Report
@@ Coverage Diff @@
## main #4536 +/- ##
=====================================
Coverage 80.8% 80.8%
=====================================
Files 150 150
Lines 10367 10371 +4
=====================================
+ Hits 8383 8387 +4
Misses 1840 1840
Partials 144 144
|
pellared
changed the title
withMessageEvents
pellared
approved these changes
Nov 7, 2023
dashpole
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4533