otelgrpc: Refine tests to use a net socket instead of a buffer #4503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadVikingGod
requested review from
dashpole,
hanyuancheung and
a team
as code owners
pellared
reviewed
Nov 2, 2023
instrumentation/google.golang.org/grpc/otelgrpc/test/grpc_test.go
Outdated
Show resolved
Hide resolved
|
I am fine with the tests in this PR and I would love to see them as a part of #4322 As for me #4503 (comment) can be addressed in a separate PR. |
|
Given this is less than 300 lines and we've talked a decent amount about this already, I'm in favor of combining this with the PR this is intended to test. 👍 |
This is because I can't reproduce the panic locally
MadVikingGod
added
the
Skip Changelog
Codecov Report
@@ Coverage Diff @@
## main #4503 +/- ##
=====================================
Coverage 80.8% 80.8%
=====================================
Files 150 150
Lines 10366 10366
=====================================
+ Hits 8376 8382 +6
+ Misses 1844 1840 -4
+ Partials 146 144 -2 |
pellared
approved these changes
Nov 6, 2023
instrumentation/google.golang.org/grpc/otelgrpc/test/grpc_test.go
Outdated
Show resolved
Hide resolved
pellared
changed the title
dashpole
approved these changes
Nov 6, 2023
pellared
reviewed
Nov 6, 2023
instrumentation/google.golang.org/grpc/otelgrpc/test/grpc_stats_handler_test.go
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the changes proposed by @pellared in #4322.
Currently, I haven't addressed the metric failure because when #4322 lands, those attributes will be removed.