Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics are non conformant to semantic conventions #4501

Open
sk- opened this issue Nov 1, 2023 · 3 comments
Open

Metrics are non conformant to semantic conventions #4501

sk- opened this issue Nov 1, 2023 · 3 comments
Labels
area: instrumentation Related to an instrumentation package bug Something isn't working instrumentation: otelhttp

Comments

@sk-
Copy link

sk- commented Nov 1, 2023

Description

Two of the metrics provided by the otelhttp package don't follow the semantic conventions. These metrics:

  • http.server.response_content_length which should be called http.server.request.body.size and be an histogram (see spec)
    http.server.request_content_length which should be called http.server.response.body.size and be an histogram (see spec

Expected behavior

The otelhttp package (and all packages in this repo) should follow the semantic conventions.

@sk- sk- added area: instrumentation Related to an instrumentation package bug Something isn't working instrumentation: otelhttp labels Nov 1, 2023
@MadVikingGod
Copy link
Contributor

That was changed in the 1.21 and later version of the semantic convention. Currently, otelhttp is on 1.20, which uses http.request_content_length

There is work that needs to be done to be able to transition from 1.20 to later, because of the introduced breaking changes in the semantic convention, but should resolve this issue with it.

@dashpole
Copy link
Contributor

@MadVikingGod is there an issue tracking the work that needs to be done to get past the breaking changes in semconv? It looks like we do have v1.23.1 generated: open-telemetry/opentelemetry-go#4749

@danilobuerger
Copy link

The metric names have been changed, but haven't been migrated to histogram

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: instrumentation Related to an instrumentation package bug Something isn't working instrumentation: otelhttp
Projects
None yet
Development

No branches or pull requests

4 participants