[config] introduce config package #4376
Conversation
There was a problem hiding this comment.
Note that the generated model code lives in a package that includes the version of the schema in the package name.
I'm not sure if that's the right thing to do, but it is similar to what is done for semconv.
With semconv we intented to support all kind of versions. For the configuration, I suppose it is OK to support the latest configuration schema version. Therefore, I do not think we should include a version in the package name. Similar PR: open-telemetry/opentelemetry-go#4538
pellared
dismissed
their stale review
Dismissing my previous review after a chat with MrAlias.
This change introduces the config package with the following changes: - add go-jsonschema tool to tools.go - add `make genjsonschema` target to Makefile - run the genjsonschema target to generate the code from the opentelemetry configuration schema - add a readme for the package Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten
force-pushed
the
codeboten/genjsonschema
branch
from
27a4eec
to
d8cf141
Compare
|
@pellared i've moved |
Signed-off-by: Alex Boten <aboten@lightstep.com>
|
@pellared well i tried removing the I've re-added it, though since it's automatically added I didn't update it to 1.21.2. Appreciate any thoughts/advice here |
This code will live in the opentelemetry-go-contrib repo in the future. This depends on open-telemetry/opentelemetry-go-contrib#4376 --------- Signed-off-by: Alex Boten <aboten@lightstep.com>
This change introduces the config package with the following changes:
make genjsonschematarget to MakefileThis is a scoped down version of #4228
Note that the generated model code lives in a package that includes the version of the schema in the package name. I'm not sure if that's the right thing to do, but it is similar to what is done for semconv.