Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: Create SDK from model #4371

Closed
pellared opened this issue Oct 2, 2023 · 2 comments · Fixed by #4804
Closed

config: Create SDK from model #4371

pellared opened this issue Oct 2, 2023 · 2 comments · Fixed by #4804
Assignees
Labels
area: config Related to config functionality
Milestone

Comments

@pellared
Copy link
Member

pellared commented Oct 2, 2023

Add a function which creates SDK from model.

E.g.

package config

// NewSDK creates SDK providers based on the configuration model.
func NewSDK(ctx, context.Context, c *OpenTelemetryConfiguration) (*SDK, error) {}

type SDK struct {}
func (sdk *SDK) Shutdown() error {}
func (sdk *SDK) TraceProvider() *trace.TraceProvider {}
func (sdk *SDK) MeterProvider() *meter.MeterProvider {}
@pellared pellared added the area: config Related to config functionality label Oct 2, 2023
@pellared
Copy link
Member Author

PTAL @codeboten

@codeboten
Copy link
Contributor

@pellared already started on this, please assign it to me when you have a moment

codeboten pushed a commit to codeboten/opentelemetry-go-contrib that referenced this issue Dec 21, 2023
This PR is another attempt at filling in the SDK details for NewSDK. It breaks the open-telemetry#4617 per signal to make it more manageable to review.

Part of open-telemetry#4371

Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten pushed a commit to codeboten/opentelemetry-go-contrib that referenced this issue Jan 11, 2024
Follow up to open-telemetry#4741, does the same but for metric signal.

Fixes open-telemetry#4371

Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten pushed a commit to codeboten/opentelemetry-go-contrib that referenced this issue Jan 16, 2024
Follow up to open-telemetry#4741, does the same but for metric signal.

Fixes open-telemetry#4371

Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten pushed a commit to codeboten/opentelemetry-go-contrib that referenced this issue Jan 22, 2024
Follow up to open-telemetry#4741, does the same but for metric signal.

Fixes open-telemetry#4371

Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten pushed a commit to codeboten/opentelemetry-go-contrib that referenced this issue Mar 4, 2024
Follow up to open-telemetry#4741, does the same but for metric signal.

Fixes open-telemetry#4371

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
codeboten added a commit to codeboten/opentelemetry-go-contrib that referenced this issue Mar 4, 2024
Follow up to open-telemetry#4741, does the same but for metric signal.

Fixes open-telemetry#4371

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
codeboten added a commit to codeboten/opentelemetry-go-contrib that referenced this issue Apr 12, 2024
Follow up to open-telemetry#4741, does the same but for metric signal.

Fixes open-telemetry#4371

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@MrAlias MrAlias added this to the v1.26.0 milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: config Related to config functionality
Projects
None yet
3 participants