Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

otelgrpc: Update examples to use stats Handlers #4317

Closed
pellared opened this issue Sep 18, 2023 · 1 comment · Fixed by #4325
Closed

otelgrpc: Update examples to use stats Handlers #4317

pellared opened this issue Sep 18, 2023 · 1 comment · Fixed by #4325
Assignees
@fatsheep9146
Labels
area: instrumentation Related to an instrumentation package documentation Improvements or additions to documentation instrumentation: otelgrpc
Milestone
v1.20.0/v0.45.0

Comments

@pellared
Copy link
Member

pellared commented Sep 18, 2023 •
edited

I think we should also update the existing examples to use the new instrumentation.

I propose to:

  1. Merge this PR
  2. Create an issue for https://github.com/open-telemetry/opentelemetry-go-contrib/pull/3002/files#r1209293763
  3. Update the existing examples to use the new functionality.
  4. Deprecate the interceptors so that they are available in next release.
  5. After the next release remove the interceptors.

@open-telemetry/go-approvers please upvote/downvote if you agree or not. Feel free to leave any additional feedback.

Originally posted by @pellared in #3002 (review)

otelgrpc: Update examples to use stats Handlers
@pellared
Copy link
Member Author

FYI @fatsheep9146

@pellared pellared added this to the v0.45.0 milestone Sep 18, 2023
@pellared pellared added area: instrumentation Related to an instrumentation package instrumentation: otelgrpc documentation Improvements or additions to documentation labels Sep 18, 2023
@pellared pellared mentioned this issue Sep 19, 2023
Merged
@fatsheep9146 fatsheep9146 mentioned this issue Sep 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fatsheep9146 fatsheep9146

Labels
area: instrumentation Related to an instrumentation package documentation Improvements or additions to documentation instrumentation: otelgrpc
Projects
None yet
Milestone
v1.20.0/v0.45.0
Development

Successfully merging a pull request may close this issue.

otelgrpc: Modify example to use grpc.StatsHandler fatsheep9146/opentelemetry-go-contrib
2 participants
@pellared @fatsheep9146