Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mux] Add request filters like otelhttp #4230

Merged
merged 5 commits into from Sep 6, 2023

Conversation

RangelReale
Copy link
Contributor

Based on the otelhttp code.

Fixes #896

@RangelReale RangelReale requested a review from a team as a code owner August 22, 2023 17:58
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #4230 (fa42803) into main (3ad5a2c) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4230   +/-   ##
=====================================
  Coverage   79.4%   79.4%           
=====================================
  Files        166     166           
  Lines      10363   10374   +11     
=====================================
+ Hits        8233    8244   +11     
  Misses      1996    1996           
  Partials     134     134           
Files Changed Coverage
...mentation/github.com/gorilla/mux/otelmux/config.go 100.0%
...trumentation/github.com/gorilla/mux/otelmux/mux.go 100.0%

CHANGELOG.md Outdated Show resolved Hide resolved
@pellared
Copy link
Member

pellared commented Sep 6, 2023

@RangelReale Thank you for your contribution 🎉

FYI #2834 (comment)

It is possible that in the future we will deprecate most HTTP instrumentation libraries in favor of having otelhttp in better shape and more extensible. We for should would add examples how to use it with libraries like mux or chi.

@pellared pellared merged commit aab5f49 into open-telemetry:main Sep 6, 2023
27 checks passed
@RangelReale RangelReale deleted the mux-http-filter branch September 8, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question: how to ignore healthcheck endpoint with otelmux
3 participants