Update the otelgocql to use the latest otel pkg #4199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `skd/metric/aggregation` package was deprecated in favor of using the added aggregation types in `sdk/metric`. This updates the otelgocql example to use the new types. Note, this is the only change needed to bring contrib into a compile-able state with commit d78820e9050cd63daebdb4b82202f10d9c2b66e3 of go.opentelemetry.io/otel*.
MrAlias
added
Skip Changelog
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4199 +/- ##
=======================================
+ Coverage 79.4% 81.2% +1.7%
=======================================
Files 166 168 +2
Lines 10360 10406 +46
=======================================
+ Hits 8230 8451 +221
+ Misses 1996 1808 -188
- Partials 134 147 +13 |
dashpole
approved these changes
Aug 17, 2023
MadVikingGod
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
skd/metric/aggregationpackage was deprecated in favor of using the added aggregation types insdk/metric. This updates the otelgocql example to use the new types.Note, this is the only change needed to bring contrib into a compile-able state with commit d78820e9050cd63daebdb4b82202f10d9c2b66e3 of go.opentelemetry.io/otel*.