Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gRPC service/method URL path parsing discrepancies #4135

Merged
merged 2 commits into from Aug 7, 2023

Conversation

ash2k
Copy link
Contributor

@ash2k ash2k commented Aug 4, 2023

See grpc/grpc-go#6483 for background.

@ash2k ash2k requested review from dashpole, hanyuancheung and a team as code owners August 4, 2023 07:27
@ash2k ash2k force-pushed the grpc-url-path-parsing branch 3 times, most recently from 6cd00f1 to 189a9bf Compare August 4, 2023 08:32
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #4135 (662fa6b) into main (c00b03a) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4135   +/-   ##
=====================================
  Coverage   79.3%   79.3%           
=====================================
  Files        166     166           
  Lines      10330   10336    +6     
=====================================
+ Hits        8200    8206    +6     
  Misses      1996    1996           
  Partials     134     134           
Files Changed Coverage Δ
.../google.golang.org/grpc/otelgrpc/internal/parse.go 100.0% <100.0%> (ø)

@pellared pellared merged commit e439286 into open-telemetry:main Aug 7, 2023
22 checks passed
@ash2k ash2k deleted the grpc-url-path-parsing branch August 7, 2023 22:41
@MrAlias MrAlias added this to the v0.43.0 milestone Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants