Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autoexport: Rename IsNone to IsNoneSpanExporter #4134

Merged
merged 2 commits into from Aug 4, 2023

Conversation

pellared
Copy link
Member

@pellared pellared commented Aug 3, 2023

Fixes #4133

@pellared pellared marked this pull request as ready for review August 3, 2023 13:18
@pellared pellared requested a review from a team as a code owner August 3, 2023 13:18
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #4134 (b9e1f71) into main (40b91b8) will decrease coverage by 0.1%.
Report is 1 commits behind head on main.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #4134     +/-   ##
=======================================
- Coverage   79.3%   79.3%   -0.1%     
=======================================
  Files        166     166             
  Lines      10330   10330             
=======================================
- Hits        8200    8197      -3     
- Misses      1996    1998      +2     
- Partials     134     135      +1     
Files Changed Coverage Δ
exporters/autoexport/exporter.go 85.0% <ø> (ø)
exporters/autoexport/noop.go 42.8% <100.0%> (ø)

... and 1 file with indirect coverage changes

@pellared pellared merged commit d94e648 into open-telemetry:main Aug 4, 2023
22 checks passed
@pellared pellared deleted the rename-isnone branch August 4, 2023 08:32
@MrAlias MrAlias added this to the v0.43.0 milestone Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

autoexport: Rename IsNone to IsNoneSpanExporter
4 participants