Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autoexport: Handle OTEL_TRACES_EXPORTER=none #4130

Merged
merged 6 commits into from Aug 2, 2023

Conversation

pellared
Copy link
Member

Fixes #4013 (option A)

@pellared pellared marked this pull request as ready for review July 31, 2023 11:09
@pellared pellared requested a review from a team as a code owner July 31, 2023 11:09
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@525d6c0). Click here to learn what that means.
The diff coverage is 50.0%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff           @@
##             main   #4130   +/-   ##
======================================
  Coverage        ?   79.3%           
======================================
  Files           ?     166           
  Lines           ?   10330           
  Branches        ?       0           
======================================
  Hits            ?    8200           
  Misses          ?    1996           
  Partials        ?     134           
Files Changed Coverage Δ
exporters/autoexport/noop.go 42.8% <42.8%> (ø)
exporters/autoexport/registry.go 100.0% <100.0%> (ø)

@pellared pellared requested a review from dashpole July 31, 2023 14:17
exporters/autoexport/noop.go Show resolved Hide resolved
@pellared pellared merged commit 40b91b8 into open-telemetry:main Aug 2, 2023
22 checks passed
@pellared pellared deleted the autoexport-none branch August 2, 2023 06:32
@MrAlias MrAlias added this to the v0.43.0 milestone Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

autoexport: Support none as exporter
4 participants