New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
autoexport: OTLP exporter defaults to http/protobuf protocol instead of grpc #4100
Merged
pellared
merged 6 commits into
open-telemetry:main
from
pellared:autoexport-default-to-otlp-http
Jul 27, 2023
Merged
autoexport: OTLP exporter defaults to http/protobuf protocol instead of grpc #4100
pellared
merged 6 commits into
open-telemetry:main
from
pellared:autoexport-default-to-otlp-http
Jul 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pellared
changed the title
autoexport: OTEL_EXPORTER_OTLP_PROTOCOL defaults to http/protobuf
autoexport: OTLP exporter defaults to http/protobuf protocol
Jul 26, 2023
pellared
changed the title
autoexport: OTLP exporter defaults to http/protobuf protocol
autoexport: OTLP exporter defaults to http/protobuf instead of grpc
Jul 26, 2023
pellared
changed the title
autoexport: OTLP exporter defaults to http/protobuf instead of grpc
autoexport: OTLP exporter defaults to http/protobuf protocol instead of grpc
Jul 26, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4100 +/- ##
=======================================
+ Coverage 79.1% 79.3% +0.1%
=======================================
Files 165 165
Lines 10318 10318
=======================================
+ Hits 8170 8183 +13
+ Misses 2010 2000 -10
+ Partials 138 135 -3
|
dashpole
approved these changes
Jul 26, 2023
This comment was marked as outdated.
This comment was marked as outdated.
dmathieu
approved these changes
Jul 27, 2023
MrAlias
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
https://github.com/open-telemetry/opentelemetry-specification/blob/v1.23.0/specification/protocol/exporter.md?plain=1#L152-L155
Also a bugfix https://github.com/open-telemetry/opentelemetry-specification/blob/v1.23.0/specification/configuration/sdk-environment-variables.md?plain=1#L19
What
OTLP exporter with
http/protobuf
protocol is created by default.OTEL_EXPORTER_OTLP_PROTOCOL=""
is handled the same way as ifOTEL_EXPORTER_OTLP_PROTOCOL
was unset.Testing
Unfortunately there is no easy way to test what OTLP exporter is returned (grpc vs http). My only idea was to usereflect
, but I am not sure if it is not an overkill.I decided to add the tests anyway: 8a1cf4e
I created #4102 to improve the documentation.