fix: do not ignore the error as it might be useful for upstream middlewares. #2209 #3656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pellared
reviewed
Mar 27, 2023
pellared
reviewed
Mar 27, 2023
instrumentation/github.com/labstack/echo/otelecho/test/echo_test.go
Outdated
Show resolved
Hide resolved
instrumentation/github.com/labstack/echo/otelecho/test/echo_test.go
Outdated
Show resolved
Hide resolved
pellared
approved these changes
Mar 27, 2023
instrumentation/github.com/labstack/echo/otelecho/test/echo_test.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Robert Pająk <pellared@hotmail.com>
pellared
approved these changes
Mar 27, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3656 +/- ##
=====================================
Coverage 70.1% 70.1%
=====================================
Files 147 147
Lines 6974 6974
=====================================
+ Hits 4889 4895 +6
+ Misses 1961 1957 -4
+ Partials 124 122 -2
|
dmathieu
approved these changes
Mar 28, 2023
hanyuancheung
approved these changes
Mar 31, 2023
|
@open-telemetry/go-maintainers I think this is good to merge. |
MrAlias
approved these changes
Apr 26, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error received by
otelechomiddleware is then passed back to upstream middleware instead of being swallowed.Added more test cases.
Closes: #2209