Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XRay Remote Sampler accumulates Quota balance above assigned quota #3651

Closed
jj22ee opened this issue Mar 24, 2023 · 0 comments
Closed

XRay Remote Sampler accumulates Quota balance above assigned quota #3651

jj22ee opened this issue Mar 24, 2023 · 0 comments

Comments

@jj22ee
Copy link
Contributor

jj22ee commented Mar 24, 2023

The XRay sampling rules are of format x requests per second, and a rate of y.
However, the implementation of the sampler in golang allows the x requests to accumulate over time if not used. This is not desirable as it can allow for an unexpected increase burst of sampled requests after long time periods between requests.

Issue Details:

Quota balance should be capped to 1*quota

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant