Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix aws sdk span name #3582

Merged
merged 9 commits into from
Mar 20, 2023
Merged

Conversation

nemoshlag
Copy link
Member

@nemoshlag nemoshlag commented Mar 13, 2023

Fix span name in order to match semcov Service.Operation format.

Part of #3521

@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Merging #3582 (58199b3) into main (aead737) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3582   +/-   ##
=====================================
  Coverage   70.0%   70.0%           
=====================================
  Files        147     147           
  Lines       6948    6956    +8     
=====================================
+ Hits        4865    4873    +8     
  Misses      1959    1959           
  Partials     124     124           
Impacted Files Coverage Δ
...tation/github.com/aws/aws-sdk-go-v2/otelaws/aws.go 94.1% <100.0%> (+0.5%) ⬆️

@nemoshlag nemoshlag marked this pull request as ready for review March 13, 2023 15:13
@nemoshlag nemoshlag requested review from a team and Aneurysm9 as code owners March 13, 2023 15:13
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Robert Pająk <pellared@hotmail.com>
@MrAlias MrAlias merged commit b784471 into open-telemetry:main Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants