Add autoexport to automatically configure trace exporters #2753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
reviewed
Sep 15, 2022
Co-authored-by: Tyler Yahn <codingalias@gmail.com>
Co-authored-by: Tyler Yahn <codingalias@gmail.com>
MikeGoldsmith
force-pushed
the
mike/autoexport
branch
from
b6a0c2f
to
c03aaf6
Compare
Co-authored-by: Tyler Yahn <codingalias@gmail.com>
Co-authored-by: Tyler Yahn <codingalias@gmail.com>
…telemetry-go-contrib into mike/autoexport # Conflicts: # CHANGELOG.md
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2753 +/- ##
=====================================
Coverage 79.3% 79.3%
=====================================
Files 163 165 +2
Lines 10325 10422 +97
=====================================
+ Hits 8193 8274 +81
- Misses 2000 2012 +12
- Partials 132 136 +4
|
|
Hey @MrAlias - could you give this another pass for feedback please? Thanks |
MikeGoldsmith
requested review from
jmacd,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
pellared
reviewed
May 25, 2023
pellared
reviewed
May 25, 2023
pellared
reviewed
May 25, 2023
pellared
reviewed
May 25, 2023
Co-authored-by: Robert Pająk <pellared@hotmail.com>
|
@pellared How's this? |
pellared
reviewed
May 25, 2023
Co-authored-by: Robert Pająk <pellared@hotmail.com>
MrAlias
reviewed
May 25, 2023
MrAlias
approved these changes
May 25, 2023
pellared
approved these changes
May 25, 2023
|
Is there a no-op exporter we can use with autoexport? |
I created #4013 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an autoexport package similar to autoprop that can detect and configure trace exporters, or use provided ones if none are set in environment variables.
Note: common exporters (eg otlp, jaeger, etc) cannot be pre-populated into the registry during init because they would not take into account environment variables configured before autoexport is called. This is valuable, as it both supports testing and when combined with the proposed generic config launcher (see below).
Known limitations: