Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.AspNetCore] Use static Meter and Histogram #5112

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Dec 2, 2023

Towards #4376

Changes

  • Use static Meter and Histogram
  • This should allow for multiple SDK registrations with instrumentation so that they can be disposed without affect each other.(This is also consistent with how we have defined ActivitySource and Meter for Http instrumentation)

@utpilla utpilla requested a review from a team as a code owner December 2, 2023 00:05
@utpilla utpilla changed the title [Instrumentation.AspNetCore] Use static Meter [Instrumentation.AspNetCore] Use static Meter and Histogram Dec 2, 2023
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Dec 2, 2023

Codecov Report

Merging #5112 (c6acb9e) into main (c5f5dd7) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5112      +/-   ##
==========================================
+ Coverage   83.00%   83.09%   +0.08%     
==========================================
  Files         296      296              
  Lines       12322    12320       -2     
==========================================
+ Hits        10228    10237       +9     
+ Misses       2094     2083      -11     
Flag Coverage Δ
unittests 83.09% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ry.Instrumentation.AspNetCore/AspNetCoreMetrics.cs 100.00% <100.00%> (ø)
...AspNetCore/Implementation/HttpInMetricsListener.cs 89.47% <100.00%> (+0.90%) ⬆️
...ation.AspNetCore/MeterProviderBuilderExtensions.cs 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

@utpilla utpilla merged commit 9dbd22d into open-telemetry:main Dec 2, 2023
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants